Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Null expr does not work for json field #40456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Mar 7, 2025

issue: #40455

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 7, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (a56b240) to head (aac5c12).

Files with missing lines Patch % Lines
internal/core/src/mmap/ChunkedColumn.h 50.00% 3 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (70.03%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40456      +/-   ##
==========================================
- Coverage   70.04%   70.03%   -0.02%     
==========================================
  Files         309      309              
  Lines       27725    27725              
==========================================
- Hits        19421    19417       -4     
- Misses       8304     8308       +4     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 70.03% <40.00%> (-0.02%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/storage/ChunkCache.cpp 78.36% <100.00%> (-2.34%) ⬇️
internal/core/src/mmap/ChunkedColumn.h 51.51% <50.00%> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 24.31% <0.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

czs007 pushed a commit that referenced this pull request Mar 7, 2025
issue: #40455 
pr: #40456

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants