Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Remove CPU profile to prevent blocking stop progress #40459

Merged
merged 2 commits into from
Mar 13, 2025
Merged

enhance: Remove CPU profile to prevent blocking stop progress #40459

merged 2 commits into from
Mar 13, 2025
+31 −46

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Mar 7, 2025 •
edited
Loading

pr: #40460

  • Removed CPU profile dump from util.go's pprof collection
  • Avoid potential blocking in StopCPUProfile() during shutdown
  • Maintain goroutine/heap/block/mutex profiles for diagnostics
  • Ensure safe shutdown timeout handling without profile stalls

@sre-ci-robot sre-ci-robot requested review from xiaocai2333 and yhmo March 7, 2025 08:15
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 7, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Mar 7, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Mar 7, 2025
@dosubot dosubot bot added the area/performance Performance issues label Mar 7, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (bd41701) to head (6bd5d06).
Report is 7 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40459      +/-   ##
==========================================
- Coverage   80.94%   80.93%   -0.01%     
==========================================
  Files        1421     1421              
  Lines      200868   200868              
==========================================
- Hits       162597   162582      -15     
- Misses      32596    32606      +10     
- Partials     5675     5680       +5
Components Coverage Δ
Client 79.77% <ø> (ø)
Core 70.36% <ø> (ø)
Go 82.82% <ø> (-0.01%) ⬇️

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 10, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 10, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 10, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 10, 2025
@mergify mergify bot removed the ci-passed label Mar 11, 2025
@weiliu1031 weiliu1031 force-pushed the fix_pprof_block_stop branch from b692de1 to bd2f8d9 Compare March 11, 2025 03:46
@weiliu1031
enhance: Remove CPU profile to prevent blocking stop progress
f1f7067 
- Removed CPU profile dump from util.go's pprof collection
- Avoid potential blocking in StopCPUProfile() during shutdown
- Maintain goroutine/heap/block/mutex profiles for diagnostics
- Ensure safe shutdown timeout handling without profile stalls

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031
fix review comment
6bd5d06 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the fix_pprof_block_stop branch from bd2f8d9 to 6bd5d06 Compare March 12, 2025 04:08
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

@weiliu1031 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Mar 13, 2025
congqixia
congqixia approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4a3a1b7 into milvus-io:2.5 Mar 13, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia

@xiaocai2333 xiaocai2333

@yhmo yhmo

Assignees

@congqixia congqixia

Labels
approved area/performance Performance issues ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @sre-ci-robot @congqixia