enhance: Remove CPU profile to prevent blocking stop progress #40460
+31
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
dosubot
bot
added
the
kind/improvement
|
@weiliu1031 E2e jenkins job failed, comment |
|
@weiliu1031 cpp-unit-test check failed, comment |
|
/run-cpu-e2e |
|
rerun cpp-unit-test |
|
rerun ut |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #40460 +/- ##
==========================================
- Coverage 82.19% 80.56% -1.64%
==========================================
Files 1165 1474 +309
Lines 179833 207555 +27722
==========================================
+ Hits 147817 167218 +19401
- Misses 25965 34277 +8312
- Partials 6051 6060 +9
🚀 New features to boost your workflow:
|
- Removed CPU profile dump from util.go's pprof collection - Avoid potential blocking in StopCPUProfile() during shutdown - Maintain goroutine/heap/block/mutex profiles for diagnostics - Ensure safe shutdown timeout handling without profile stalls Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
fix_pprof_block_stop_master
branch
from
3a8e1d9 to
6687b5c
Compare
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
fix_pprof_block_stop_master
branch
from
6687b5c to
03d6e72
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Mar 13, 2025
pr: #40460 - Removed CPU profile dump from util.go's pprof collection - Avoid potential blocking in StopCPUProfile() during shutdown - Maintain goroutine/heap/block/mutex profiles for diagnostics - Ensure safe shutdown timeout handling without profile stalls --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #39735
related to #39726