Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add duplicated type/index params check creating collection #40462

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

congqixia
Copy link
Contributor

Related to #40461

Related to milvus-io#40461

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Mar 7, 2025
@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo March 7, 2025 08:30
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 7, 2025
Copy link
Contributor

mergify bot commented Mar 7, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (a56b240) to head (e1db36b).
Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40462       +/-   ##
===========================================
+ Coverage   70.04%   80.50%   +10.45%     
===========================================
  Files         309     1474     +1165     
  Lines       27725   207408   +179683     
===========================================
+ Hits        19421   166980   +147559     
- Misses       8304    34349    +26045     
- Partials        0     6079     +6079     
Components Coverage Δ
Client 79.69% <ø> (∅)
Core 70.03% <ø> (-0.02%) ⬇️
Go 82.25% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/create_collection_task.go 90.92% <100.00%> (ø)

... and 1165 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 7, 2025
@tedxu
Copy link
Contributor

tedxu commented Mar 11, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3899b0f into milvus-io:master Mar 11, 2025
23 of 25 checks passed
sre-ci-robot pushed a commit that referenced this pull request Mar 11, 2025
…#40465)

Cherry-pick from master
pr: #40462
Related to #40461

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia deleted the fix/check_dup_params branch March 11, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed component/rootcoord dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants