Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support get segment binlogs info with new interface GetSegmentsInfo #40464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

issue: #40341

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/internal-api labels Mar 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Mar 7, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Mar 7, 2025
Copy link
Contributor

mergify bot commented Mar 7, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 85.07463% with 20 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (2ca2e2d) to head (ea32814).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/impl.go 77.21% 13 Missing and 5 partials ⚠️
internal/distributed/proxy/service.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40464      +/-   ##
==========================================
- Coverage   82.15%   80.53%   -1.63%     
==========================================
  Files        1165     1474     +309     
  Lines      179766   207610   +27844     
==========================================
+ Hits       147692   167202   +19510     
- Misses      26000    34325    +8325     
- Partials     6074     6083       +9     
Components Coverage Δ
Client 79.74% <ø> (ø)
Core 70.01% <ø> (∅)
Go 82.28% <85.07%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/distributed/proxy/client/client.go 93.70% <100.00%> (+0.18%) ⬆️
...nternal/distributed/proxy/httpserver/handler_v2.go 92.69% <100.00%> (+0.13%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 83.09% <100.00%> (+0.74%) ⬆️
internal/distributed/proxy/service.go 84.32% <0.00%> (-0.24%) ⬇️
internal/proxy/impl.go 84.03% <77.21%> (-0.09%) ⬇️

... and 342 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the support_get_segmentInfo-m branch from 9c2733e to ea32814 Compare March 10, 2025 10:12
@mergify mergify bot added the ci-passed label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api ci-passed dco-passed DCO check passed. go Pull requests that update Go code kind/feature Issues related to feature request from users size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants