Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Add duplicated type/index params check creating collection #40465

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #40462
Related to #40461

Related to milvus-io#40461

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 7, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 7, 2025
@dosubot dosubot bot added component/rootcoord PR | need cherry-pick need cherry pick to other branches labels Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (2846cc5) to head (da32371).
Report is 9 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40465      +/-   ##
==========================================
- Coverage   82.68%   80.92%   -1.76%     
==========================================
  Files        1115     1419     +304     
  Lines      172162   200518   +28356     
==========================================
+ Hits       142347   162267   +19920     
- Misses      24137    32580    +8443     
+ Partials     5678     5671       -7     
Components Coverage Δ
Client 79.73% <ø> (ø)
Core 70.17% <ø> (∅)
Go 82.82% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/rootcoord/create_collection_task.go 90.92% <100.00%> (+0.23%) ⬆️

... and 333 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 7, 2025
@tedxu
Copy link
Contributor

tedxu commented Mar 11, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 004668b into milvus-io:2.5 Mar 11, 2025
20 checks passed
@congqixia congqixia deleted the cp25/40462 branch March 11, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed component/rootcoord dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm PR | need cherry-pick need cherry pick to other branches size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants