Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.5] Support get segment binlogs info with new interface GetSegmentsInfo #40466

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

issue: #40341

master pr: #40464

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 7, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Mar 7, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Mar 7, 2025
Copy link
Contributor

mergify bot commented Mar 7, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 85.07463% with 20 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (b0ad3d9) to head (a764395).
Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/impl.go 77.21% 13 Missing and 5 partials ⚠️
internal/distributed/proxy/service.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40466      +/-   ##
==========================================
- Coverage   82.67%   80.92%   -1.75%     
==========================================
  Files        1115     1421     +306     
  Lines      172326   201000   +28674     
==========================================
+ Hits       142471   162668   +20197     
- Misses      24170    32643    +8473     
- Partials     5685     5689       +4     
Components Coverage Δ
Client 79.77% <ø> (ø)
Core 70.36% <ø> (∅)
Go 82.81% <85.07%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/distributed/proxy/client/client.go 93.70% <100.00%> (+0.18%) ⬆️
...nternal/distributed/proxy/httpserver/handler_v2.go 92.69% <100.00%> (+0.13%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 83.09% <100.00%> (+0.74%) ⬆️
internal/distributed/proxy/service.go 85.11% <0.00%> (-0.24%) ⬇️
internal/proxy/impl.go 83.73% <77.21%> (-0.09%) ⬇️

... and 325 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaocai2333 xiaocai2333 force-pushed the support_get_segmentInfo branch from 0a96b75 to 12f5abe Compare March 10, 2025 10:09
Copy link
Contributor

mergify bot commented Mar 10, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the support_get_segmentInfo branch from 12f5abe to ad24e7a Compare March 10, 2025 12:27
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the support_get_segmentInfo branch from ad24e7a to a764395 Compare March 12, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. go Pull requests that update Go code kind/feature Issues related to feature request from users size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants