Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add query view proto, interface, event and utilities #40467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Mar 7, 2025

issue: #40451

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 7, 2025
@sre-ci-robot sre-ci-robot requested review from czs007 and xige-16 March 7, 2025 08:50
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 80.52434% with 52 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (d6a650b) to head (4ad7b31).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...dinator/view/qviews/coordview/shardview/builder.go 0.00% 14 Missing ⚠️
internal/coordinator/view/qviews/recovery/impls.go 87.71% 4 Missing and 3 partials ⚠️
...al/coordinator/view/qviews/syncer/client/client.go 0.00% 6 Missing ⚠️
internal/coordinator/view/qviews/syncer/syncer.go 0.00% 5 Missing ⚠️
internal/coordinator/view/qviews/view.go 91.22% 3 Missing and 2 partials ⚠️
internal/coordinator/view/qviews/events/event.go 85.71% 4 Missing ⚠️
internal/coordinator/view/qviews/utils.go 88.57% 3 Missing and 1 partial ⚠️
internal/coordinator/view/qviews/balance_attr.go 91.66% 2 Missing ⚠️
internal/coordinator/view/qviews/events/syncer.go 80.00% 2 Missing ⚠️
internal/coordinator/view/qviews/node.go 81.81% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40467       +/-   ##
===========================================
+ Coverage   70.03%   80.50%   +10.46%     
===========================================
  Files         309     1488     +1179     
  Lines       27725   207676   +179951     
===========================================
+ Hits        19417   167182   +147765     
- Misses       8308    34406    +26098     
- Partials        0     6088     +6088     
Components Coverage Δ
Client 79.74% <ø> (∅)
Core 70.03% <ø> (ø)
Go 82.24% <80.52%> (∅)
Files with missing lines Coverage Δ
...al/coordinator/view/qviews/events/event_notfier.go 100.00% <100.00%> (ø)
...ordinator/view/qviews/events/nop_event_notifier.go 100.00% <100.00%> (ø)
internal/coordinator/view/qviews/events/op.go 100.00% <100.00%> (ø)
...nternal/coordinator/view/qviews/events/recovery.go 66.66% <66.66%> (ø)
internal/coordinator/view/qviews/balance_attr.go 91.66% <91.66%> (ø)
internal/coordinator/view/qviews/events/syncer.go 80.00% <80.00%> (ø)
internal/coordinator/view/qviews/node.go 81.81% <81.81%> (ø)
internal/coordinator/view/qviews/events/event.go 85.71% <85.71%> (ø)
internal/coordinator/view/qviews/utils.go 88.57% <88.57%> (ø)
internal/coordinator/view/qviews/syncer/syncer.go 0.00% <0.00%> (ø)
... and 4 more

... and 1165 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyezh chyezh force-pushed the enhance_qv_state_machine_protos branch from 2c86fad to 396b85d Compare March 10, 2025 01:46
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the enhance_qv_state_machine_protos branch from 396b85d to 4ad7b31 Compare March 10, 2025 01:46
Copy link
Contributor

mergify bot commented Mar 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 10, 2025

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Mar 10, 2025

rerun go-sdk

@chyezh
Copy link
Contributor Author

chyezh commented Mar 10, 2025

rerun cpp-unit-test

@chyezh
Copy link
Contributor Author

chyezh commented Mar 10, 2025

rerun go-sdk

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Mar 10, 2025

rerun go-sdk

@mergify mergify bot added the ci-passed label Mar 10, 2025
@weiliu1031
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants