Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topic grpc config and transport strategy and make sure publish deadline is set #496

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Mar 4, 2025

Closes Issue #1133

Publish deadline was not getting set. This PR fixes that and adds a TopicGrpcConfiguration and TopicTransportStrategy to make the publish timeout configurable.

@anitarua
Copy link
Contributor Author

anitarua commented Mar 4, 2025

Hm, should we remove ubuntu-20.04 from github actions workflow? Can't get the 3 tests using this version to run:

This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-01. For more details, see actions/runner-images#11101

@anitarua anitarua marked this pull request as ready for review March 4, 2025 19:42
@anitarua anitarua requested a review from a team March 4, 2025 19:42
@malandis
Copy link
Contributor

malandis commented Mar 4, 2025

Hm, should we remove ubuntu-20.04 from github actions workflow? Can't get the 3 tests using this version to run:

This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-01. For more details, see actions/runner-images#11101

The only reason ubuntu-20.04 is there now is because the older python versions part of our test matrix are not bundled in ubundu-24.04. I timeboxed installing those older versions with a different method on ubuntu-24.04 but did not find an easy way. We can raise the issue again internally.

@anitarua anitarua merged commit bfac90d into main Mar 6, 2025
10 checks passed
@anitarua anitarua deleted the publish-deadline branch March 6, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants