-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mentions #7538
base: main
Are you sure you want to change the base?
feat: Mentions #7538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outstanding!
I need to test it though, let me come back to you soon ..
"tributejs": "^5.1.3", | ||
"vue-tribute": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to go to the devDependencies
Thanks asbiin Instead of the current tabs: Timeline would show all the posts, notes, documents, photos, calls, life events together ordered by date with a filtering system at the top to show/hide these. There would also be buttons at the top to create each of these different events. |
This push add 2 main features:
(See the last item in the activity feed. This has nothing to do with mentions, it relies on which contacts are linked to the post in the existing way).
In this commit, mentions look like this in the edit box @"Tony Smith", and go into the database as a token {{{CONTACT-ID:xxxx-xxxx-xxxxxx|Tony Smith}}}. The reason the name is also in the token is to act as a fall back name only, should the contact get deleted, the user's intent does not get lost. The view will always attempt to retrieve the up to date name information from the databasae.
There are no breaking changes.
Currently the only contacts that can be selected are the ones already linked to the post in the submenu. My preference for monica is actually removal of contacts in this post form entirely and relying on mentions to connect the post to users only. That way, any contacts in the journal can be picked when making a mention. This can be introduced in a non-breaking way if needed (by adding all the mentions at the bottom to all previously linked contacts to all posts).
To do:
I wanted the thoughts of @djaiss @asbiin and the community before proceeding further.