Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm 10.5.2 support #13662

Closed
gepbird opened this issue Mar 4, 2025 · 5 comments
Closed

Pnpm 10.5.2 support #13662

gepbird opened this issue Mar 4, 2025 · 5 comments
Labels
in linear Issue or PR has been created in Linear for internal review Needs Feedback Waiting for further input or clarification.

Comments

@gepbird
Copy link

gepbird commented Mar 4, 2025

Bug Description

When trying to build n8n with pnpm 10.5.2, I get the following error:

ERROR  The following patches were not applied: bull@4.12.1, pkce-challenge@3.0.0, pyodide@0.23.4, @types/express-serve-static-core@4.17.43, @types/ws@8.5.4, @types/uuencode@0.0.3, vue-tsc@2.1.10
Either remove them from "patchedDependencies" or update them to match packages in your dependencies.

In nixpkgs we try to use the latest version of packages, therefore currently pnpm 10.5.2. I understand that you tested it with pnpm 10.2.1, this is more of a "feature request" than a bug report.

To Reproduce

  1. clone the repo
  2. have pnpm 10.5.2 installed
  3. pnpm i
  4. observe the error

Expected behavior

It installs dependencies without errors

Operating System

NixOS

n8n Version

1.81.4

Node.js Version

22.14.0

Database

SQLite (default)

Execution mode

main (default)

@Joffcom
Copy link
Member

Joffcom commented Mar 4, 2025

Hey @gepbird,

We have created an internal ticket to look into this which we will be tracking as "GHC-1042"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Mar 4, 2025
@netroy
Copy link
Member

netroy commented Mar 4, 2025

Unable to reproduce this on the latest master, even on a fresh clone.

Image

That said, while we understand the need to use the latest packages, we do not recommend latest versions of dev-tooling for end users.
Would it be possible to install n8n from npm, instead of compiling it from source?

@Joffcom Joffcom added Needs Feedback Waiting for further input or clarification. and removed Needs Feedback Waiting for further input or clarification. labels Mar 4, 2025
@gepbird
Copy link
Author

gepbird commented Mar 4, 2025

Thanks for your quick response!

Interesting that you can't reproduce it, I'll also investigate it soon. We'd like to build n8n from source, currently 1.75.2 builds fine with pnpm 9.15.5, we've been using the latest pnpm 9.x.x without issues so far.

Also other pnpm commands fail in n8n's directory, and weirdly there's another error when leaving and entering the directory:

Image

Removing the pnpm pin seems to do the job.

@netroy
Copy link
Member

netroy commented Mar 5, 2025

can you try installing pnpm via corepack?

@Joffcom Joffcom added the Needs Feedback Waiting for further input or clarification. label Mar 5, 2025
@gepbird
Copy link
Author

gepbird commented Mar 7, 2025

This was a pnpm bug which is fixed in https://github.com/pnpm/pnpm/releases/tag/v10.6.1:

Sorry for the noise about it here

@gepbird gepbird closed this as completed Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review Needs Feedback Waiting for further input or clarification.
Projects
None yet
Development

No branches or pull requests

3 participants