-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Update PATCH /projects/:projectId/folders/:folderId
endpoint to allow moving folder (no-changelog)
#13574
Open
RicardoE105
wants to merge
5
commits into
ado-3281-be-update-endpoint-that-return-workflows-and-folders-to-also
Choose a base branch
from
ado-3166-be-add-endpoint-to-move-folders
base: ado-3281-be-update-endpoint-that-return-workflows-and-folders-to-also
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to update the parent folder (moving operation)
/projects/:projectId/folders/:folderId
endpoint/projects/:projectId/folders/:folderId
endpoint to allow moving folder
/projects/:projectId/folders/:folderId
endpoint to allow moving folder/projects/:projectId/folders/:folderId
endpoint to allow moving folder (no-changelog)
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Cadiac
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good catch on preventing the issue on moving workflows to the same folder that's being deleted
…olders-to-also' into ado-3166-be-add-endpoint-to-move-folders
4 tasks
/projects/:projectId/folders/:folderId
endpoint to allow moving folder (no-changelog)/projects/:projectId/folders/:folderId
endpoint to allow moving folder (no-changelog)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #13548
Chain of upstream PRs as of 2025-02-27
PR feat(core): Add endpoint GET
/projects/:projectId/folders
(no-changelog) #13519:master
←ado-3270-be-add-endpoint-to-list-folders
PR feat(core): Add
subFolderCount
to GET/workflows
and/folders
(no-changelog) #13548:ado-3270-be-add-endpoint-to-list-folders
←ado-3281-be-update-endpoint-that-return-workflows-and-folders-to-also
/projects/:projectId/folders/:folderId
endpoint to allow moving folder (no-changelog) #13574 (THIS ONE):ado-3281-be-update-endpoint-that-return-workflows-and-folders-to-also
←ado-3166-be-add-endpoint-to-move-folders
Summary
1 - Update endpoint to allow moving folder to another parent.
2 - Update delete endpoint to get parameters via query string instead of body. See discussions here.
3 - Update delete endpoint to account for case when the user is trying to transfer content to the same folder it's deleting.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3166/[be]-add-endpoint-to-move-folders
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)