Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SpreadsheetFile): add relax quote option #13607

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fank
Copy link

@Fank Fank commented Mar 1, 2025

Summary

It does allow quotes in unquotes csv fields.

Related Linear tickets, Github issues, and Community forum posts

relates to #13594

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Before:
image

n8n:dev: [Node] Invalid Opening Quote: a quote is found on field 4 at line 58863, value is "ROOMZ Display EDU SILVER incl. software subscription (1 year "

After:
image
While no error has been seen in the console.

image

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Mar 1, 2025
@Joffcom
Copy link
Member

Joffcom commented Mar 1, 2025

Hey @Fank,

Thanks for the PR, We have created "GHC-1010" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@dana-gill dana-gill requested a review from ShireenMissi March 3, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants