Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Disable deactivated node execution #13643

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Mar 3, 2025

Summary

Prevent deactivated node execution as they're not executed either when the workflow gets executed.
A deactivated node needs to be activated before being executed individually.

Related Linear tickets, Github issues, and Community forum posts

PAY-2620

Review / Merge checklist

  • PR title and summary are descriptive.
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Mar 3, 2025
@cstuncsik cstuncsik marked this pull request as ready for review March 5, 2025 15:23
Copy link
Contributor

@MarcL MarcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

cypress bot commented Mar 11, 2025

n8n    Run #9697

Run Properties:  status check passed Passed #9697  •  git commit c39685bbc0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-2620-bug-error-when-running-deactivated-node
Run status status check passed Passed #9697
Run duration 04m 40s
Commit git commit c39685bbc0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 439
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants