fix(core): Pass NODE_PATH to task runners
#13652
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
|
We should allowlist it in the launcher config also. Currently this is undocumented, so we might want to decide if we should make it official or drop it in v2. |
ivov
approved these changes
Mar 5, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pass-NODE_PATH-to-task-runners
|
| Run status |
|
| Run duration | 04m 46s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
440
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NODE_PATHdetermines where external node modules will berequire'd from.Without the same value
NODE_PATHin task-runners as in the parent process, any user code that usesrequire, and used to work on the old sandbox, will now stop working on task-runners.This PR copies over this env variable to ensure backward-compatibility.
Related Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/enabling-task-runners-breaks-workflows/83774
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)