-
Notifications
You must be signed in to change notification settings - Fork 33.2k
refactor: createVectorStoreNode
refactoring and embeddings batching support (no-changelog)
#13674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Introduce new 'Embedding Batch Size' parameter for vector store nodes - Support batched document processing in node version 1.1+ - Update documentation and tests to reflect new batching functionality
04a8f4e
to
579d8da
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally, and seems to work nicely. I like how this splits up the operations and adds tests for each operation individually. Nice work.
Request some changes, which are mostly docs-changes in the readme and some comments that don't really add a lot of value at the moment.
packages/frontend/editor-ui/src/components/canvas/WorkflowCanvas.test.ts
Outdated
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/vector_store/shared/createVectorStoreNode/README.md
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/vector_store/shared/createVectorStoreNode/README.md
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/vector_store/shared/createVectorStoreNode/README.md
Outdated
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/vector_store/shared/createVectorStoreNode/README.md
Outdated
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/vector_store/shared/createVectorStoreNode/README.md
Outdated
Show resolved
Hide resolved
Thanks for the review, @jeanpaul! I tweaked the docs a bit and included also a very small fix for filtering in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments and fixing AI-740 in the process too! Looks good to me, and works as expected, so let's ship it!
n8n
|
Project |
n8n
|
Branch Review |
ai-749-speed-up-vector-store-ingestion
|
Run status |
|
Run duration | 04m 39s |
Commit |
|
Committer | Oleg Ivaniv |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
5
|
|
0
|
|
440
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
1 similar comment
✅ All Cypress E2E specs passed |
… support (no-changelog) (#13674)
… support (no-changelog) (#13674)
… support (no-changelog) (#13674)
… support (no-changelog) (#13674)
Got released with |
… support (no-changelog) (n8n-io#13674)
… support (no-changelog) (n8n-io#13674)
Summary
Changes
Vector Store Architecture Improvements
Embedding Performance Optimization
UI Rendering Performance
In my tests populating 500 items to QDrant vector store went from ~5mins to 10s.
Before
CleanShot.2025-03-04.at.12.50.00121221.mp4
After
CleanShot.2025-03-04.at.12.46.28.mp4
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-749
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)