fix(editor): Fix opening 'Schema' view by default after opening binary nodes #13676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should some e2e test be added for this scenario? |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
mutdmour
approved these changes
Mar 4, 2025
CharlieKolb
approved these changes
Mar 4, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ado-3220-schema-view-opening-a-ndv-with-binary-inputs-changes-the
|
| Run status |
|
| Run duration | 04m 47s |
| Commit |
|
| Committer | Jaakko Husso |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
440
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Cadiac
deleted the
ado-3220-schema-view-opening-a-ndv-with-binary-inputs-changes-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default RunData NDV tab to open should be
schemaon non binary nodes, even after a binary node has been opened. If user opened a node with binary inputs the default would switch totable, and this PR changes that back toschema.default-tab.mp4
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3220/schema-view-opening-a-ndv-with-binary-inputs-changes-the-default-view
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)