Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Show error details in resource locator dropdown #13679

Merged
merged 9 commits into from
Mar 10, 2025

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

Showing real error details in RLC dropdown:
image

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-3066

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Mar 4, 2025
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 97.27891% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...src/components/ResourceLocator/ResourceLocator.vue 94.20% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding coverage and fixing this. Should have had this from the beginning.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Mar 4, 2025

n8n    Run #9660

Run Properties:  status check passed Passed #9660  •  git commit c09bfa0940: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ADO-3066-show-errors-in-rlc
Run status status check passed Passed #9660
Run duration 04m 36s
Commit git commit c09bfa0940: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 440
View all changes introduced in this branch ↗︎

@mutdmour mutdmour self-requested a review March 4, 2025 19:37
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback

Copy link
Contributor

github-actions bot commented Mar 5, 2025

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 630608c into master Mar 10, 2025
37 of 38 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3066-show-errors-in-rlc branch March 10, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants