refactor(core): Try to unify the various webhook response modes #13680
+460
−545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
force-pushed
the
webhook-response-promise-refactor-part-1
branch
from
91a827a to
c8dfa3f
Compare
ivov
reviewed
Mar 11, 2025
Comment on lines
+32
to
+37
| export type IWebhookResponsePromiseData = | ||
| | { noWebhookResponse: true } | ||
| | { | ||
| noWebhookResponse?: false; | ||
| response: IN8nHttpFullResponse; | ||
| }; |
There was a problem hiding this comment.
Would it be possible for this to be type IWebhookResponsePromiseData = null | IN8nHttpFullResponse?
There was a problem hiding this comment.
Listing a few dimensions here, not 100% if this is what you had in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is attempt 4, and the CI is likely not going to be happy.
Might need to extract bits out of this PR into smaller PRs.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)