fix: Set Profiler logger to initialized when configuration load fails #3015
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the file is created. Fixes #3014
chore: Update Profiler NuGet Package Reference to v10.37.0.12. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
jaffinito
previously approved these changes
Mar 3, 2025
nrcventura
reviewed
Mar 4, 2025
nrcventura
requested changes
Mar 4, 2025
chore: Update Profiler NuGet Package Reference to v10.37.0.14. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
tippmar-nr
changed the title
chore: Update Profiler NuGet Package Reference to v10.37.0.16. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
nrcventura
reviewed
Mar 6, 2025
…elic/newrelic-dotnet-agent into fix/empty-profiler-log-file
nrcventura
previously approved these changes
Mar 6, 2025
chore: Update Profiler NuGet Package Reference to v10.37.0.19. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
nrcventura
previously approved these changes
Mar 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3015 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 476 476
Lines 30536 30536
Branches 3416 3416
=======================================
Hits 25075 25075
Misses 4661 4661
Partials 800 800
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nrcventura
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Set Profiler logger to initialized when configuration load fails. (#3015)
END_COMMIT_OVERRIDE
The profiler log file wasn't being set as "initialized" until after the configuration was successfully loaded. This prevented errors that occurred during configuration load from being written to the log file, with the symptom being a profiler log with no content.
This fix sets the logger to "initialized" just before the second attempt to load the configuration, ensuring that the exception thrown during that attempt gets logged.
Sample output:
Fixes #3014