-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add instrumentation for In-Process Azure Functions #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Update Profiler NuGet Package Reference to v10.36.0.10. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
jaffinito
reviewed
Feb 28, 2025
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/AzureFunction/InProcessFunctionDetails.cs
Outdated
Show resolved
Hide resolved
chore: Update Profiler NuGet Package Reference to v10.37.0.30. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
jaffinito
previously approved these changes
Mar 4, 2025
nrcventura
reviewed
Mar 4, 2025
...ons/Providers/Wrapper/AzureFunction/AzureFunctionInProcessExecuteWithWatchersAsyncWrapper.cs
Outdated
Show resolved
Hide resolved
nrcventura
reviewed
Mar 4, 2025
src/Agent/NewRelic/Agent/Core/AgentHealth/AgentHealthReporter.cs
Outdated
Show resolved
Hide resolved
nrcventura
reviewed
Mar 4, 2025
...Agent/Extensions/Providers/Wrapper/AzureFunction/AzureFunctionInProcessInvokeAsyncWrapper.cs
Show resolved
Hide resolved
…github.com/newrelic/newrelic-dotnet-agent into feature/azure-functions-in-process-support
chore: Update Profiler NuGet Package Reference to v10.38.0.36. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
+ Coverage 82.11% 82.17% +0.06%
==========================================
Files 476 476
Lines 30536 30553 +17
Branches 3416 3418 +2
==========================================
+ Hits 25075 25108 +33
+ Misses 4661 4644 -17
- Partials 800 801 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nrcventura
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HttpTrigger
functions will read incoming distributed trace headers if the trigger method has a parameter of typeSystem.Net.Http.HttpRequest
,Microsoft.AspNetCore.Http.DefaultHttpRequest
orMicrosoft.AspNetCore.Http.HttpRequest
.ServiceBusTrigger
functions will read incoming distributed trace headers if the trigger method has a parameter of typeAzure.Messaging.ServiceBus.ServiceBusReceivedMessage
. Trace headers are expected to be in theApplicationProperties
collection.ApplicationProperties
collection for Triggers with return a type ofAzure.Messaging.ServiceBus.ServiceBusMessage
.Supportability/DotNet/AzureFunction/Worker/InProcess
(or/Isolated
)Supportability/DotNet/AzureFunction/Trigger/{TriggerType}
where{TriggerType}
is the name of the trigger attribute (minus theTriggerAttribute
suffix).Supportability/DotNet/AzureFunctionMode/Enabled
metric has been replaced withSupportability/DotNet/AzureFunctionMode/enabled
andSupportability/DotNet/AzureFunctionMode/disabled
.Includes integration tests.
Author Checklist
Reviewer Checklist