Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update mssql to 2022-latest #3009

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Conversation

tippmar-nr
Copy link
Member

Updates the unbounded services MSSQL configuration to run MSSQL 2022-latest. Also updates Dockerfile and setup.sh to work with the latest version.

This matches what is already running on the unbounded services EC2 instance.

@tippmar-nr tippmar-nr requested a review from a team as a code owner February 28, 2025 22:37
@tippmar-nr tippmar-nr enabled auto-merge (squash) February 28, 2025 22:37
@nr-ahemsath
Copy link
Member

I don't actually see an update to the version being pulled from Docker (i.e. the top of the Dockerfile still looks like:

FROM mcr.microsoft.com/mssql/server:2017-latest

Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (caeb705) to head (73b0b74).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3009   +/-   ##
=======================================
  Coverage   82.10%   82.11%           
=======================================
  Files         476      476           
  Lines       30536    30536           
  Branches     3416     3416           
=======================================
+ Hits        25073    25075    +2     
+ Misses       4662     4661    -1     
+ Partials      801      800    -1     
Flag Coverage Δ
Agent 83.17% <ø> (+<0.01%) ⬆️
Profiler 72.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@tippmar-nr tippmar-nr merged commit 7161b79 into main Mar 4, 2025
97 checks passed
@tippmar-nr tippmar-nr deleted the chore/mssql-docker-update branch March 4, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants