Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify logging messages for invalid attributes on custom events and logging events #2244

Open
jtduffy opened this issue Feb 25, 2025 · 1 comment
Labels
1 Story Point Estimate

Comments

@jtduffy
Copy link
Contributor

jtduffy commented Feb 25, 2025

A couple of the WARNING messages for invalid attributes imply that the entire transaction or logging event will be ignored if an attribute is invalid. These should be more clear that only the invalid attribute will be dropped.

Agent.LOG.log(Level.WARNING, "Custom event [{0}] with invalid attributes key or value of null was reported for a transaction but ignored."

Agent.LOG.log(Level.WARNING, "Log event with invalid attributes key or value of null was reported for a transaction but ignored."

The current text is:

Custom event [{0}] with invalid attributes key or value of null was reported for a transaction but ignored. 
Each key should be a String and each value should be a String, Number, or Boolean. Key: {1} / Value: {2}

An improved message would be:

Custom event [{0}] with invalid attributes key or value of null was reported for a transaction. 
This attribute will be ignored. Each key should be a String and each value should be a String, 
Number, or Boolean. Key: {1} / Value: {2}
@workato-integration
Copy link

@jtduffy jtduffy added the 1 Story Point Estimate label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Story Point Estimate
Projects
Development

No branches or pull requests

1 participant