Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include 'background_color' in list of supported keys #51181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

doubleO8
Copy link

@doubleO8 doubleO8 commented Mar 2, 2025

@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

@doubleO8 thank you for your pull request. Could you please sign off your commit as per our contribution guidelines?
Should be as simple as git commit --amend -s.

Also please adjust your commit message to follow the conventional commits, e.g. simply:

- include 'background_color' in list of supported keys
+ fix(theming): include `background_color` in list of supported keys

Signed-off-by: doubleO8 <wb008@hdm-stuttgart.de>
@doubleO8 doubleO8 force-pushed the fix-occ-theming-config-background_color branch from d0f14f1 to da51459 Compare March 8, 2025 10:30
@doubleO8 doubleO8 requested a review from a team as a code owner March 8, 2025 10:30
@doubleO8 doubleO8 requested review from ArtificialOwl, artonge and provokateurin and removed request for a team March 8, 2025 10:30
@provokateurin provokateurin requested a review from susnux March 8, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: theming:config background_color neither shown nor configurable
3 participants