Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass hide download attribute while creating the share to fix github issue 50788 #51250

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: pass hide download attribute while creating the share to fix github issue 50788 #51250

wants to merge 5 commits into from
+167 −26

Conversation

yemkareems
Copy link
Contributor

@yemkareems yemkareems commented Mar 5, 2025 •
edited by susnux
Loading

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems added the 3. to review Waiting for reviews label Mar 5, 2025
@yemkareems yemkareems self-assigned this Mar 5, 2025
@yemkareems
Copy link
Contributor Author

/compile

@susnux susnux mentioned this pull request Mar 5, 2025
Closed
@susnux susnux marked this pull request as ready for review March 5, 2025 20:36
@susnux susnux requested a review from a team as a code owner March 5, 2025 20:36
@susnux susnux requested review from skjnldsv, Pytal and szaimen and removed request for a team March 5, 2025 20:36
@susnux susnux added this to the Nextcloud 32 milestone Mar 5, 2025
@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from 36c1585 to 8ef5647 Compare March 5, 2025 23:28
@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

/compile

@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from eeafeee to bba7972 Compare March 6, 2025 07:41
@szaimen szaimen removed their request for review March 6, 2025 10:11
yemkareems and others added 3 commits March 13, 2025 11:36
@yemkareems @susnux
fix: pass hide download attribute while creating the share to fix git…
4bc6905 
…hub issue 50788

Signed-off-by: yemkareems <yemkareems@gmail.com>
@susnux
fix(files_sharing): ugly hacks to update permissions on share creation
011dcaa 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files_sharing): make sure IDs are unique for HTML elements
d095aef 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from bba7972 to ff2851b Compare March 13, 2025 10:36
@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/compile

@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/backport to stable30

@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/backport to stable29

@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from 5e984e4 to c460ffd Compare March 13, 2025 11:03
@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/compile

susnux and others added 2 commits March 13, 2025 15:32
@susnux
test: add cypress tests for sharing download permission
8d2f7f3 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command @susnux
chore(assets): Recompile assets
f8b4912 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from 8b972ac to f8b4912 Compare March 13, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv

@Pytal Pytal

At least 2 approving reviews are required to merge this pull request.

Assignees

@yemkareems yemkareems

Labels
3. to review Waiting for reviews backport-request bug feature: sharing
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

[Bug]: Hide download in share creation is not retained after it is checked while share is created
3 participants
@yemkareems @susnux @nextcloud-command