-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create linter system #191
Conversation
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
9bad793
to
5e1c0ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass will finish in a bit
do we have ability to warn if it's an unknown stability level ? |
I didn't create this rule but it's a good idea, I can develop this. |
Wdyt of adding a capability here to ignore only specific linting errors? I.e. being able to ignore an invalid |
+1 for ingnoring rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a clean code! LGTM! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not too complicated have the rules deactivated if not LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, is there any way to test this?
clone this repo |
I was referring to more automated tests without having to take that step you mentioned. |
Agreed some unit tests would be cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some unit tests, @araujogui?
Sure, I'll push this tomorrow. Disabling rules too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
GitHub seems to be automatically stripping ANSI escape sequences, so tests pass locally and fail in CI |
Any workaround? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yep, |
Description
Create linter system
Validation
Run CLI
Related Issues
Fixes #56
Check List