stream: fix sizeAlgorithm validation in WritableStream
#57280
Merged
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
jasnell
approved these changes
Mar 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57280 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 630 630
Lines 184908 184910 +2
Branches 36181 36188 +7
=======================================
+ Hits 166874 166879 +5
- Misses 11061 11064 +3
+ Partials 6973 6967 -6
|
JungMinu
approved these changes
Mar 2, 2025
daeyeon
added
author ready
github-actions
bot
removed
the
request-ci
jazelly
approved these changes
Mar 3, 2025
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c566639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeAlgorithmseems to be set toundefinedwhen the stream is closed as well. This patch adds the uncheckedclosedstate to the assertion.https://streams.spec.whatwg.org/#writable-stream-default-controller-process-close
Fixes: #57272
Refs: #56067