Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make even more improvements to error handling #57264

Closed
wants to merge 1 commit into from
Closed

src: make even more improvements to error handling #57264

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 1, 2025

Propagate more errors correctly.

@jasnell jasnell requested review from anonrig and aduh95 March 1, 2025 21:01
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/loaders
  • @nodejs/net
  • @nodejs/sqlite
  • @nodejs/startup
  • @nodejs/url
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.52874% with 50 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (db00f94) to head (066c75d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/node_serdes.cc 50.00% 9 Missing and 5 partials ⚠️
src/node_file.cc 40.00% 2 Missing and 4 partials ⚠️
src/node_sqlite.cc 40.00% 3 Missing and 3 partials ⚠️
src/spawn_sync.cc 14.28% 3 Missing and 3 partials ⚠️
src/inspector_js_api.cc 20.00% 1 Missing and 3 partials ⚠️
src/module_wrap.cc 0.00% 1 Missing and 1 partial ⚠️
src/node_builtins.cc 0.00% 1 Missing and 1 partial ⚠️
src/node_contextify.cc 0.00% 1 Missing and 1 partial ⚠️
src/node_url.cc 33.33% 1 Missing and 1 partial ⚠️
src/process_wrap.cc 0.00% 1 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57264      +/-   ##
==========================================
- Coverage   90.20%   90.20%   -0.01%     
==========================================
  Files         630      630              
  Lines      185166   185192      +26     
  Branches    36227    36253      +26     
==========================================
+ Hits       167036   167050      +14     
- Misses      11117    11126       +9     
- Partials     7013     7016       +3
Files with missing lines Coverage Δ
src/node_messaging.cc 82.92% <100.00%> (-0.27%) ⬇️
src/timers.cc 86.95% <100.00%> (+0.23%) ⬆️
src/crypto/crypto_tls.cc 78.12% <75.00%> (-0.05%) ⬇️
src/node_buffer.cc 67.43% <50.00%> (+0.20%) ⬆️
src/module_wrap.cc 72.24% <0.00%> (-0.21%) ⬇️
src/node_builtins.cc 77.75% <0.00%> (-0.67%) ⬇️
src/node_contextify.cc 80.50% <0.00%> (-0.33%) ⬇️
src/node_url.cc 79.00% <33.33%> (-0.24%) ⬇️
src/process_wrap.cc 66.66% <0.00%> (-0.71%) ⬇️
src/tcp_wrap.cc 75.78% <0.00%> (-1.48%) ⬇️
... and 5 more

... and 29 files with indirect coverage changes

mcollina
mcollina approved these changes Mar 2, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2025
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell jasnell force-pushed the jasnell/moar-errorhandling-2 branch from a607707 to 3b6a2c2 Compare March 4, 2025 17:36
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65575/

@jasnell
Copy link
Member Author

jasnell commented Mar 4, 2025

CI passed although lint ci job is still broken. PR passes linting locally. Asking @nodejs/tsc for permission to go ahead and land.

@jasnell jasnell force-pushed the jasnell/moar-errorhandling-2 branch from 3b6a2c2 to 066c75d Compare March 5, 2025 01:17
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65580/

jasnell added a commit that referenced this pull request Mar 5, 2025
@jasnell
src: make even more improvements to error handling
157b36b 
PR-URL: #57264
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell
Copy link
Member Author

jasnell commented Mar 5, 2025

Landed in 157b36b

@jasnell jasnell closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@anonrig anonrig

@aduh95 aduh95

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @mcollina @anonrig