-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: add optional callback to crypto.diffieHellman #57274
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
3e30c14
to
dcc1f44
Compare
Initial read through looks good. Will do a full review pass and sign off once it's not draft. |
5d0f506
to
fc80d87
Compare
fc80d87
to
e6d0554
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Before anyone jumps the gun, despite CI possibly passing (soon-ish) - I'd like this to wait for @tniessen's review. |
e6d0554
to
e1f142b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57274 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 630 630
Lines 184908 184915 +7
Branches 36181 36197 +16
==========================================
+ Hits 166874 166876 +2
+ Misses 11061 11042 -19
- Partials 6973 6997 +24
|
Let me see if I can do more for coverage |
e1f142b
to
374b548
Compare
This comment was marked as outdated.
This comment was marked as outdated.
374b548
to
71ff746
Compare
This comment was marked as outdated.
This comment was marked as outdated.
71ff746
to
47f7784
Compare
This adds optional callback for the stateless
crypto.diffieHellman
method to allow for the crypto execution to happen in libuv's threadpool.In the asynchronous case, the OpenSSL code/library/reason error decoration is missing (because it relies on retrieving details from OpenSSL's error queue, which does not work across threads), this is something we will have to refactor in a semver-major with a broader callback methods error handling reimagining (as I've discussed privately with @tniessen), this is likely a larger endeavor now that ncrypto is in the mix.
cc @jasnell