-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: improve myers diff performance #57279
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
puskin94:improve-myers-diff-performance
Mar 6, 2025
Merged
assert: improve myers diff performance #57279
nodejs-github-bot
merged 1 commit into
nodejs:main
from
puskin94:improve-myers-diff-performance
Mar 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57279 +/- ##
==========================================
- Coverage 90.26% 90.23% -0.03%
==========================================
Files 630 630
Lines 184634 184912 +278
Branches 36137 36180 +43
==========================================
+ Hits 166654 166852 +198
- Misses 11022 11063 +41
- Partials 6958 6997 +39
🚀 New features to boost your workflow:
|
c6f4f0b
to
3a76c93
Compare
BridgeAR
approved these changes
Mar 3, 2025
confidence improvement accuracy (*) (**) (***)
assert/assertion-error.js datasetName='objects' size=10 n=10 *** 146.69 % ±11.02% ±14.84% ±19.67%
assert/assertion-error.js datasetName='objects' size=10 n=200 *** 464.19 % ±4.82% ±6.49% ±8.61%
assert/assertion-error.js datasetName='objects' size=10 n=50 *** 314.21 % ±8.46% ±11.40% ±15.13%
assert/assertion-error.js datasetName='objects' size=10 n=500 *** 530.52 % ±2.50% ±3.37% ±4.47%
assert/assertion-error.js datasetName='objects' size=100 n=10 *** 1137.02 % ±14.04% ±18.92% ±25.11%
assert/assertion-error.js datasetName='objects' size=100 n=200 *** 1253.63 % ±29.90% ±40.29% ±53.49%
assert/assertion-error.js datasetName='objects' size=100 n=50 *** 1239.92 % ±26.41% ±35.60% ±47.26%
assert/assertion-error.js datasetName='objects' size=100 n=500 *** 1289.22 % ±19.54% ±26.33% ±34.96% |
LiviaMedeiros
approved these changes
Mar 6, 2025
Landed in 395439b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assert
Issues and PRs related to the assert subsystem.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-benchmark-ci
PR that need a benchmark CI run.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #57242
I reviewed the codebase and identified both some quick-win optimizations and the primary reason for the performance degradation when generating the error diff.
@Rymar, using the code example you posted in the related issue for testing during the fix, we should achieve performance levels close to what we had with the previous linear algorithm that Node.js used before switching to the Myers algorithm.
/cc @BridgeAR