tools: extract target abseil to abseil.gyp #57289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both V8 and perfetto depends on abseil. When perfetto support is enabled, V8 also depends on perfetto. In order to share abseil between perfetto and V8 targets, and avoid cycle dependencies between `v8.gyp` and `perfetto.gyp`, this extracts target `abseil` from `v8.gyp` to an independent file `abseil.gyp`.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Mar 3, 2025
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Mar 3, 2025
targos
approved these changes
Mar 4, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4e222ae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both V8 and perfetto depends on abseil. When perfetto support is
enabled, V8 also depends on perfetto.
In order to share abseil between perfetto and V8 targets, and avoid
cycle dependencies between
v8.gypandperfetto.gyp, this extractstarget
abseilfromv8.gypto an independent fileabseil.gyp.Refs: nodejs/diagnostics#654