Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip uv-thread-name on IBM i #57299

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

abmusse
Copy link
Contributor

@abmusse abmusse commented Mar 3, 2025

Similar to AIX, IBM i does not support get/set thread name from libuv.
See: libuv/libuv#4599 (comment)

CC
@nodejs/platform-ibmi

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 3, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 3, 2025

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (47a59bd) to head (dea3465).
Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #57299   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         630      630           
  Lines      184920   184920           
  Branches    36186    36185    -1     
=======================================
+ Hits       166874   166879    +5     
+ Misses      11059    11057    -2     
+ Partials     6987     6984    -3     

see 28 files with indirect coverage changes

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2025
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8342183 into nodejs:main Mar 5, 2025
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8342183

@abmusse abmusse deleted the ibmi-skip-uv-thread-name branch March 5, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants