src: refine ncrypto more #57300
Open
src: refine ncrypto more #57300
+486
−306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57300 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 630 630
Lines 184920 184884 -36
Branches 36188 36187 -1
=======================================
- Hits 166876 166848 -28
+ Misses 11064 11056 -8
Partials 6980 6980
|
anonrig
approved these changes
Mar 3, 2025
jasnell
force-pushed
the
jasnell/more-ncrypto-more-fun
branch
from
0c51603 to
c5839c9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
An eventual goal for ncrypto is to completely abstract away details of working directly with openssl in order to make it easier to work with multiple different openssl/boringssl versions. As part of that we want to move away from direct reliance on specific openssl APIs in the runtime and instead go through the ncrypto abstractions. Not only does this help other runtimes trying to be compatible with Node.js, but it helps Node.js also by reducing the complexity of the crypto code in Node.js itself.
jasnell
force-pushed
the
jasnell/more-ncrypto-more-fun
branch
from
c5839c9 to
ec43618
Compare
jasnell
force-pushed
the
jasnell/more-ncrypto-more-fun
branch
from
ec43618 to
d111ff9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@nodejs/build ... getting a weird error with the |
The linter in Jenkins is currently running on Node.js 20.18.2. I'm guessing something has landed recently on main or eslint that needs require(esm) which hasn't been backported to Node.js 20 yet. |
|
@richardlau ... thank you. @nodejs/tsc ... asking for permission to land this (when it is ready) without node-test-linter passing in CI assuming it is not fixed by then. linting is passing locally. |
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
|
FWIW I think I figured out why the eslint is failing #57314 - there is a breaking dependabot upgrade. |
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
commit-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An eventual goal for ncrypto is to completely abstract away
details of working directly with openssl in order to make it
easier to work with multiple different openssl/boringssl versions.
As part of that we want to move away from direct reliance on
specific openssl APIs in the runtime and instead go through
the ncrypto abstractions. Not only does this help other
runtimes trying to be compatible with Node.js, but it helps
Node.js also by reducing the complexity of the crypto code
in Node.js itself.