doc: use more clear name in getSystemErrorMessage's example #57310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous example, `name` actually points to the `message`. So I changed this name to fit the context of the example. Fixes: nodejs#57305
nodejs-github-bot
added
doc
joyeecheung
approved these changes
Mar 4, 2025
jasnell
approved these changes
Mar 4, 2025
lpinca
approved these changes
Mar 4, 2025
lpinca
added
the
commit-queue
jasnell
added
author ready
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
|
There's really no reason to make this one wait the full 48 hours |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57310 ✔ Done loading data for nodejs/node/pull/57310 ----------------------------------- PR info ------------------------------------ Title doc: use more clear name in getSystemErrorMessage's example (#57310) Author ikuma-t <tadokorodev@gmail.com> (@IkumaTadokoro, first-time contributor) Branch IkumaTadokoro:improve-get-system-error-message-example -> nodejs:main Labels util, doc, fast-track, author ready Commits 1 - doc: use more clear name in getSystemErrorMessage's example Committers 1 - ikuma-t <tadokorodev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/57310 Fixes: https://github.com/nodejs/node/issues/57305 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57310 Fixes: https://github.com/nodejs/node/issues/57305 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Mar 2025 12:50:25 GMT ✔ Approvals: 3 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/57310#pullrequestreview-2657616856 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57310#pullrequestreview-2658029718 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57310#pullrequestreview-2658746867 ℹ This PR is being fast-tracked ✘ This PR needs to wait 40 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13661968166 |
geeksilva97
approved these changes
Mar 4, 2025
geeksilva97
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57310 ✔ Done loading data for nodejs/node/pull/57310 ----------------------------------- PR info ------------------------------------ Title doc: use more clear name in getSystemErrorMessage's example (#57310) Author ikuma-t <tadokorodev@gmail.com> (@IkumaTadokoro, first-time contributor) Branch IkumaTadokoro:improve-get-system-error-message-example -> nodejs:main Labels util, doc, fast-track, author ready Commits 1 - doc: use more clear name in getSystemErrorMessage's example Committers 1 - ikuma-t <tadokorodev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/57310 Fixes: https://github.com/nodejs/node/issues/57305 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57310 Fixes: https://github.com/nodejs/node/issues/57305 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Mar 2025 12:50:25 GMT ✔ Approvals: 4 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/57310#pullrequestreview-2657616856 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57310#pullrequestreview-2658029718 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57310#pullrequestreview-2658746867 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/57310#pullrequestreview-2659477548 ℹ This PR is being fast-tracked ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13665753502 |
jakecastelli
removed
the
commit-queue-failed
jakecastelli
pushed a commit
that referenced
this pull request
Mar 7, 2025
In the previous example, `name` actually points to the `message`. So I changed this name to fit the context of the example. Fixes: #57305 PR-URL: #57310 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
|
Landed in 8032e96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous example,
nameactually points to themessage. So I changed this name to fit the context of the example.Fixes: #57305