-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: import rather than require ESLint plugins #57315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
cjihrig
approved these changes
Mar 4, 2025
91d3b40
to
7a92501
Compare
jasnell
approved these changes
Mar 4, 2025
geeksilva97
approved these changes
Mar 4, 2025
joyeecheung
approved these changes
Mar 4, 2025
richardlau
approved these changes
Mar 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57315 +/- ##
=======================================
Coverage 90.19% 90.20%
=======================================
Files 630 630
Lines 185131 185164 +33
Branches 36204 36228 +24
=======================================
+ Hits 166985 167030 +45
- Misses 11140 11143 +3
+ Partials 7006 6991 -15 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Mar 4, 2025
anonrig
approved these changes
Mar 4, 2025
RafaelGSS
approved these changes
Mar 4, 2025
Commit Queue failed- Loading data for nodejs/node/pull/57315 ✔ Done loading data for nodejs/node/pull/57315 ----------------------------------- PR info ------------------------------------ Title tools: import rather than require ESLint plugins (#57315) Author Michaël Zasso <targos@protonmail.com> (@targos) Branch targos:import-eslint-tools -> nodejs:main Labels tools, author ready, needs-ci Commits 1 - tools: import rather than require ESLint plugins Committers 1 - Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/57315 Refs: https://github.com/nodejs/node/pull/57314 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57315 Refs: https://github.com/nodejs/node/pull/57314 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Mar 2025 17:14:35 GMT ✔ Approvals: 8 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658382963 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658394429 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658418036 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658424312 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658461081 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658742467 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658769475 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658854755 ✔ Last GitHub CI successful ✘ No full Jenkins CI runs detected ℹ Last Linter CI on 2025-03-04T17:22:43Z: https://ci.nodejs.org/job/node-test-linter/59243/ - Querying data for job/node-test-pull-request/59243/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13704553297 |
Landed in 27f98c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #57314