Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: import rather than require ESLint plugins #57315

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

targos
Copy link
Member

@targos targos commented Mar 4, 2025

Refs: #57314

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 4, 2025
@targos targos force-pushed the import-eslint-tools branch from 91d3b40 to 7a92501 Compare March 4, 2025 17:19
@targos
Copy link
Member Author

targos commented Mar 4, 2025

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (2cff256) to head (7a92501).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #57315   +/-   ##
=======================================
  Coverage   90.19%   90.20%           
=======================================
  Files         630      630           
  Lines      185131   185164   +33     
  Branches    36204    36228   +24     
=======================================
+ Hits       166985   167030   +45     
- Misses      11140    11143    +3     
+ Partials     7006     6991   -15     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 4, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 6, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/57315
✔  Done loading data for nodejs/node/pull/57315
----------------------------------- PR info ------------------------------------
Title      tools: import rather than require ESLint plugins (#57315)
Author     Michaël Zasso <targos@protonmail.com> (@targos)
Branch     targos:import-eslint-tools -> nodejs:main
Labels     tools, author ready, needs-ci
Commits    1
 - tools: import rather than require ESLint plugins
Committers 1
 - Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/57315
Refs: https://github.com/nodejs/node/pull/57314
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57315
Refs: https://github.com/nodejs/node/pull/57314
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 04 Mar 2025 17:14:35 GMT
   ✔  Approvals: 8
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658382963
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658394429
   ✔  - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658418036
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658424312
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658461081
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658742467
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658769475
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57315#pullrequestreview-2658854755
   ✔  Last GitHub CI successful
   ✘  No full Jenkins CI runs detected
   ℹ  Last Linter CI on 2025-03-04T17:22:43Z: https://ci.nodejs.org/job/node-test-linter/59243/
- Querying data for job/node-test-pull-request/59243/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/13704553297

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 27f98c3 into nodejs:main Mar 7, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 27f98c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.