Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket diagnostic channels lack request identities #4081

Open
legendecas opened this issue Mar 4, 2025 · 0 comments
Open

WebSocket diagnostic channels lack request identities #4081

legendecas opened this issue Mar 4, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@legendecas
Copy link
Member

This would solve...

The diagnostic channels for WebSocket connections have no request identities to chain up diagnostic information. Listeners of these channels can not associate each diagnostic events with a certain request with the limited information.

For example, undici:websocket:socket_error only provides an error object, without a hint of which websocket request caused the error. So do channels like undici:websocket:open, undici:websocket:ping, and undici:websocket:pong.

The implementation should look like...

The WebSocket diagnostic channel should also provide a consistent request identity (object), like the WebSocket instance.

Additional context

@legendecas legendecas added the enhancement New feature or request label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant