add node-gyp config, fix npm-version config warning
#8129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
wraithgar
force-pushed
the
gar/node-gyp-config
branch
4 times, most recently
from
fa27659 to
1fdd854
Compare
This was referenced Mar 5, 2025
wraithgar
changed the title
node-gyp confignode-gyp config, fix npm-version config warning
wraithgar
force-pushed
the
gar/node-gyp-config
branch
from
1fdd854 to
a513338
Compare
This formalizes the `node-gyp` config that is eventually consumed by [@npmcli/run-script](npm.im/@npmcli/run-script). That module will need to be updated so that it can accept this config and use it if found, only falling back to its current behavior by default.
wraithgar
force-pushed
the
gar/node-gyp-config
branch
from
a513338 to
98cca2e
Compare
9 tasks
reggi
previously approved these changes
Mar 6, 2025
reggi
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formalizes the
node-gypconfig that is eventually consumed by @npmcli/run-script.We will want to land this update in
@npmcli/run-scriptand include it here.This also warns when
npm-versionis being set by the user.