fix: make npm run autocomplete work with workspaces
#8135
Merged
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlstronaut
changed the title
npm run autocomplete to work with workspacesnpm run autocomplete work with workspaces
owlstronaut
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR makes
npm runcompletion to take workspaces into account in case of cwd is inside workspace dir it will autocompletes fromscriptssection of nearest workspace's package.Former behavoiur was to autocomplete everything from workspace root package, it has no sense since when you are in workspace directory script which will be suggested in such manner will not work. So there was a mismatch between the script launch and the autocomplete hint areas.
References
Fixes #7114