clients/go: Add e2e Go client test #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
aefhm
added
p:2
aefhm
force-pushed
the
xz/328-go-e2e
branch
2 times, most recently
from
992b575 to
3a9ff41
Compare
aefhm
force-pushed
the
xz/328-go-e2e
branch
2 times, most recently
from
c8ebaf5 to
0ecdb30
Compare
aefhm
changed the title
matevz
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Thanks for your effort. I realized @CedarMist implemented a big chunk of #328 already inside #422 (spinning up sapphire-localnet, writing an e2e test inside clients/go that actually connects to it and runs tests). See my comment below on the next steps.
aefhm
force-pushed
the
xz/328-go-e2e
branch
4 times, most recently
from
dcb2c78 to
b3268b5
Compare
aefhm
commented
Feb 17, 2025
aefhm
force-pushed
the
xz/328-go-e2e
branch
2 times, most recently
from
705cb70 to
24a1e64
Compare
aefhm
force-pushed
the
xz/328-go-e2e
branch
2 times, most recently
from
a3ed6c2 to
76e454f
Compare
matevz
approved these changes
Feb 18, 2025
aefhm
force-pushed
the
xz/328-go-e2e
branch
2 times, most recently
from
b317030 to
b7aa5d1
Compare
aefhm
force-pushed
the
xz/328-go-e2e
branch
2 times, most recently
from
9bed34f to
1fb7144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #328 by using https://github.com/oasisprotocol/demo-starter-go as a submodule for end-to-end testing. The drawback is that approach is less consistent with current behavior inside
examples/but introduces less code.