Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle being logged out of octobox.io #11

Closed
andrew opened this issue Nov 1, 2021 · 2 comments · Fixed by #13
Closed

Properly handle being logged out of octobox.io #11

andrew opened this issue Nov 1, 2021 · 2 comments · Fixed by #13
Assignees
@andrew
Labels
bug Something isn't working

Comments

@andrew
Copy link
Member

andrew commented Nov 1, 2021

Currently if you're logged out of octobox.io, the extension just never shows. Instead it should show a prompt to log in to enable it.
@andrew andrew added the bug Something isn't working label Nov 1, 2021
@andrew andrew self-assigned this Nov 1, 2021
@andrew
Copy link
Member Author

andrew commented Nov 16, 2021

This will need a proper login flow and storage of an api token to get it working with chrome rather than piggy backing on existing cookies.

Something like redirecting to a logged in page on octobox.io (/extension maybe) which then triggers the extension to store the token in chrome.storage which then can be used for all future api requests.

Also thinking that the api should probably be separated out within the octobox web app into /api to turn off cors and skip cookies.

@andrew
Copy link
Member Author

andrew commented Nov 23, 2021

new api has now been deployed on octobox.io: octobox/octobox#2852

@andrew andrew mentioned this issue Nov 25, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew andrew

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New login flow octobox/extension
1 participant
@andrew