Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to distinguish between direct review requests and team review requests #836

Open
lukashlavacka opened this issue Aug 23, 2018 · 6 comments
Assignees
Labels
enhancement Improvements and features help wanted Contributions welcome

Comments

@lukashlavacka
Copy link

lukashlavacka commented Aug 23, 2018

Similar as there is filter for Mention and Team mention there might be a way to add filter for Review requested only for direct review requests and Team review requested for requests of a team you are part of.

🐞 Problem

Being able to differentiate between Review requested and Team review requested would help especially with reviews requested by CODEOWNERS feature vs reviews requested directly.

@jules2689 jules2689 self-assigned this Aug 23, 2018
@andrew andrew added the enhancement Improvements and features label Aug 23, 2018
@jules2689 jules2689 removed their assignment Aug 31, 2018
@andrew andrew added the help wanted Contributions welcome label Sep 14, 2018
@ahayworth
Copy link

Big +1 to this - I would greatly appreciate being able to distinguish when I personally must give a review, or when my team in general needs to give a review (it affects how I prioritize my work).

I think the v3 REST API response is enough to distinguish this - the single PR endpoint has both requested_reviewers and requested_teams.

@chrisarcand chrisarcand self-assigned this May 25, 2019
@chrisarcand
Copy link
Member

I'm tired of this being a thing, as it's plagued my workflow for literally years now. I was hoping GitHub would just distinguish between review_requested and team_review_requested in their list of Notification reasons, but it's been 2.5 years since review requests shipped and by this point I imagine it could be a breaking change anyway (and there's still no V4 Notifications API, I note...) 😕

I sat down and came up with a potential solution that I'll be alpha testing next week, and will submit it if all goes well. Some early screenshots:

image
image

@NicholasEllul
Copy link

@chrisarcand any update on the progress of this?

@pradyunsg
Copy link
Contributor

See #1940

@chrisarcand
Copy link
Member

Coincidentally, there is! A big one: #2028

@banarun
Copy link

banarun commented Nov 29, 2022

Are there any plans to schedule #2028?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements and features help wanted Contributions welcome
Projects
None yet
Development

No branches or pull requests

8 participants