Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/filelog] Can we safely update filepath when rotation is detected. #36178

Closed
djaglowski opened this issue Nov 4, 2024 · 5 comments
Closed

Comments

@djaglowski
Copy link
Member

          > I was confused because the debug logs would always show the original log name, I had thought it might change to the rotated name, that was a bad assumption.

Seems like a reasonable assumption to me and something we could likely fix.

Originally posted by @djaglowski in #35777 (comment)

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Pinging code owners for receiver/filelog: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2025
@djaglowski djaglowski reopened this Mar 7, 2025
@djaglowski
Copy link
Member Author

Based on the problem reported in #35137, I think the answer to this question is that no, we shouldn't update the original file path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant