You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is important that it is the one from the last released Collector version since unreleased modules are, de facto, a different module set (their pseudoversion starts with v0.0.0) so they should be handled separately.
The text was updated successfully, but these errors were encountered:
If the script is going to read the versions.yaml from collector-core, I suggest we also get the expected versions directly from there, instead of reading them from cmd/otelcontribcol/go.mod.
We would need to add a special case to allow for pseudo-versions however (allow v0.121.0-20250305133700-badbadfacade when v0.121.0 is the latest release).
Edit: Considering the special case mentioned above, and the additional failures that would occur between the core release and the contrib release, I no longer think this is a good idea.
However, instead of using the tag for "the latest released Collector version", it would be good to use the tag for the core version currently used in contrib (making sure to strip out pseudo-versions), to avoid contrib CI failing as soon as core as been released.
Component(s)
No response
Describe the issue you're reporting
The check-collector-module-version uses https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/internal/buildscripts/modules as its source of truth for what module sets to check. I think instead it should use the
versions.yaml
file from the last released Collector version. This would reduce the need of having to manually maintain this file.It is important that it is the one from the last released Collector version since unreleased modules are, de facto, a different module set (their pseudoversion starts with
v0.0.0
) so they should be handled separately.The text was updated successfully, but these errors were encountered: