Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single source of truth for check-collector-module-version module list #38396

Open
mx-psi opened this issue Mar 5, 2025 · 1 comment
Open
Labels
ci-cd CI, CD, testing, build issues release-retro Issues discussed in a release retrospective

Comments

@mx-psi
Copy link
Member

mx-psi commented Mar 5, 2025

Component(s)

No response

Describe the issue you're reporting

The check-collector-module-version uses https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/internal/buildscripts/modules as its source of truth for what module sets to check. I think instead it should use the versions.yaml file from the last released Collector version. This would reduce the need of having to manually maintain this file.

It is important that it is the one from the last released Collector version since unreleased modules are, de facto, a different module set (their pseudoversion starts with v0.0.0) so they should be handled separately.

@jade-guiton-dd
Copy link
Contributor

jade-guiton-dd commented Mar 5, 2025

If the script is going to read the versions.yaml from collector-core, I suggest we also get the expected versions directly from there, instead of reading them from cmd/otelcontribcol/go.mod.

We would need to add a special case to allow for pseudo-versions however (allow v0.121.0-20250305133700-badbadfacade when v0.121.0 is the latest release).

Edit: Considering the special case mentioned above, and the additional failures that would occur between the core release and the contrib release, I no longer think this is a good idea.

However, instead of using the tag for "the latest released Collector version", it would be good to use the tag for the core version currently used in contrib (making sure to strip out pseudo-versions), to avoid contrib CI failing as soon as core as been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues release-retro Issues discussed in a release retrospective
Projects
None yet
Development

No branches or pull requests

2 participants