Pinging code owners:

• exporter/prometheusremotewrite: @Aneurysm9 @rapphil

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Removed the needs triage label due to the discussion from the referenced PR.

Thanks for including the references in your issue description @jmichalek132!

Hey, @crobert-1 could we please remove the bug label too? Since this is not really a bug.

As far as I can tell Grafana currently doesn't show unit even when it's present in metadata, so I will hold off on implementing this until that changes. FIlled an issue on Grafana for this grafana/grafana#80512

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/prometheusremotewrite: @Aneurysm9 @rapphil

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Not stale I will get to this.

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/prometheusremotewrite: @Aneurysm9 @rapphil

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Hey @jmichalek132 we're running into an issue where we try to use the unit from the prometheus metadata and currently its never set. Can you give an estimate as to when this will get worked on/finished? Alternatively can you give a little more direction on what needs to be refactored to allow the metric name to get included again? Happy to try and contribute as well.

Hey @jmichalek132 we're running into an issue where we try to use the unit from the prometheus metadata and currently its never set. Can you give an estimate as to when this will get worked on/finished? Alternatively can you give a little more direction on what needs to be refactored to allow the metric name to get included again? Happy to try and contribute as well.

Sorry for the late reply, I was busy with other things as for me this is a nice to have I am not sure I will get to this any time, but if you are still willing to contribute this that would be great.

To implement this you would need to fill out the unit here https://github.com/jmichalek132/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheusremotewrite/otlp_to_openmetrics_metadata.go#L65.

But as mentioned in the issue you can't just copy over the one from the OTEL you have to translate it to what prometheus expects.
Reference materials for that:

• https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheus/normalize_name.go#L106
• https://github.com/prometheus/OpenMetrics/blob/main/specification/OpenMetrics.md#unit
• https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/
• https://github.com/prometheus/OpenMetrics/blob/main/specification/OpenMetrics.md#metricfamily
• https://opentelemetry.io/docs/specs/otel/metrics/sdk_exporters/prometheus/
• https://opentelemetry.io/docs/specs/semconv/general/metrics/#units

@jmichalek132 I can't seem to add reviewers/assignees but if you can take a look and confirm that I'm on the right track then I'll flesh out the existing README with additional descriptions of the unit conversions happening.