-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] enhance flatten editor to resolve attribute key conflicts #37006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acef9c7
to
605480b
Compare
405dbca
to
9de8e9c
Compare
evan-bradley
reviewed
Jan 9, 2025
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
9de8e9c
to
d443535
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
not stale |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
not stale |
evan-bradley
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the very long delay with a review. Overall this looks good to me.
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
evan-bradley
approved these changes
Mar 4, 2025
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
atoulme
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce an option into
flatten()
editor to resolve conflicts in map keys and avoid data loss. The original behavior is perservedLink to tracking issue
Fixes #35793