Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] enhance flatten editor to resolve attribute key conflicts #37006

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jan 2, 2025

Description

Introduce an option into flatten() editor to resolve conflicts in map keys and avoid data loss. The original behavior is perserved

Link to tracking issue

Fixes #35793

@odubajDT odubajDT changed the title [pkg/ottl] enhance flatten converter to resolve attribute key conflicts [pkg/ottl] enhance flatten editor to resolve attribute key conflicts Jan 3, 2025
@odubajDT odubajDT force-pushed the flatten-conflict branch 2 times, most recently from acef9c7 to 605480b Compare January 7, 2025 13:42
@odubajDT odubajDT marked this pull request as ready for review January 7, 2025 14:29
@odubajDT odubajDT requested a review from a team as a code owner January 7, 2025 14:29
@odubajDT odubajDT force-pushed the flatten-conflict branch 2 times, most recently from 405dbca to 9de8e9c Compare January 8, 2025 08:55
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 28, 2025
@odubajDT
Copy link
Contributor Author

not stale

@github-actions github-actions bot removed the Stale label Jan 29, 2025
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 12, 2025
@odubajDT
Copy link
Contributor Author

not stale

@github-actions github-actions bot removed the Stale label Feb 13, 2025
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very long delay with a review. Overall this looks good to me.

@odubajDT odubajDT requested a review from evan-bradley March 4, 2025 06:29
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@atoulme atoulme merged commit 839e464 into open-telemetry:main Mar 4, 2025
156 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/ottl] flatten() function does not resolve attribute key conflicts when flattening
4 participants