-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(azuremonitorexporter): Fix flushes on each single Span #37217
fix(azuremonitorexporter): Fix flushes on each single Span #37217
Conversation
c287cc2
to
327026e
Compare
327026e
to
7c4f82c
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
/ping |
Could someone from the code owners please take a look at this CR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks simple enough. Testing is a bit light since we are using mocks.
Please resolve and rebase |
68f9407
to
2d80d19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This commit fixes AzureMonitorExporter issue when it calls Flush on each Span
Link to tracking issue
Fixes #37214
Testing
Unit tests updated or introduced new coverage to track number of calls to the Flush method
Documentation
No documentation added