Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azuremonitorexporter): Fix flushes on each single Span #37217

Merged

Conversation

an-mmx
Copy link
Contributor

@an-mmx an-mmx commented Jan 14, 2025

Description

This commit fixes AzureMonitorExporter issue when it calls Flush on each Span

Link to tracking issue

Fixes #37214

Testing

Unit tests updated or introduced new coverage to track number of calls to the Flush method

Documentation

No documentation added

@an-mmx an-mmx requested a review from a team as a code owner January 14, 2025 14:04
@an-mmx an-mmx requested a review from ChrsMark January 14, 2025 14:04
@github-actions github-actions bot requested a review from pcwiese January 14, 2025 14:05
@an-mmx an-mmx force-pushed the fix/azure-monitor-exporter-flush-ddos branch 2 times, most recently from c287cc2 to 327026e Compare January 20, 2025 12:54
@an-mmx an-mmx force-pushed the fix/azure-monitor-exporter-flush-ddos branch from 327026e to 7c4f82c Compare January 22, 2025 19:10
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 6, 2025
@an-mmx
Copy link
Contributor Author

an-mmx commented Feb 6, 2025

/ping

@github-actions github-actions bot removed the Stale label Feb 8, 2025
@an-mmx
Copy link
Contributor Author

an-mmx commented Feb 21, 2025

Could someone from the code owners please take a look at this CR?

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks simple enough. Testing is a bit light since we are using mocks.

@atoulme
Copy link
Contributor

atoulme commented Mar 4, 2025

@pcwiese @hgaol please review as codeowners.

@atoulme atoulme requested a review from hgaol March 4, 2025 17:13
@atoulme
Copy link
Contributor

atoulme commented Mar 6, 2025

Please resolve and rebase

@an-mmx an-mmx force-pushed the fix/azure-monitor-exporter-flush-ddos branch from 68f9407 to 2d80d19 Compare March 7, 2025 11:21
Copy link
Member

@hgaol hgaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme merged commit 3863a10 into open-telemetry:main Mar 7, 2025
171 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuremonitorexporter flushes on each first Span
3 participants