Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awscloudwatch] Migrating awscloudwatch receiver to use aws sdk v2 #37308

Merged
merged 8 commits into from
Mar 6, 2025

Conversation

LZiHaN
Copy link
Member

@LZiHaN LZiHaN commented Jan 18, 2025

Description

Migrating awscloudwatch receiver to use aws sdk v2

Link to tracking issue

refer to #36699

Testing

passes tests.

Documentation

no need to update.

@LZiHaN LZiHaN requested a review from a team as a code owner January 18, 2025 09:36
@LZiHaN LZiHaN requested a review from ChrsMark January 18, 2025 09:36
@github-actions github-actions bot requested a review from schmikei January 18, 2025 09:36
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 20, 2025
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I think we should add a changelog entry similar with a message like Upgrading to adopt aws sdk v2

@github-actions github-actions bot removed the Stale label Feb 26, 2025
@LZiHaN LZiHaN force-pushed the migrate-to-sdk-v2 branch 2 times, most recently from 1fdb852 to 7dad706 Compare February 26, 2025 09:54
@LZiHaN
Copy link
Member Author

LZiHaN commented Feb 26, 2025

Changes look good to me. I think we should add a changelog entry similar with a message like Upgrading to adopt aws sdk v2

done.

@atoulme
Copy link
Contributor

atoulme commented Mar 5, 2025

Please fix conflict

@LZiHaN LZiHaN force-pushed the migrate-to-sdk-v2 branch from 7dad706 to a30fe5c Compare March 6, 2025 02:47
@LZiHaN
Copy link
Member Author

LZiHaN commented Mar 6, 2025

Please fix conflict

done.

@atoulme atoulme merged commit 2d4cb47 into open-telemetry:main Mar 6, 2025
166 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 6, 2025
@LZiHaN LZiHaN deleted the migrate-to-sdk-v2 branch March 6, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants