Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add internal/common to CODEOWNERS and part of selection #37458

Merged
merged 5 commits into from
Mar 4, 2025

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 23, 2025

Add a metadata.yaml file to internal/common to set it as part of CODEOWNERS. This will allow us to remove it from the .github/ALLOWLIST file.

@atoulme atoulme requested a review from a team as a code owner January 23, 2025 23:51
@atoulme atoulme requested a review from fatsheep9146 January 23, 2025 23:51
@atoulme
Copy link
Contributor Author

atoulme commented Jan 23, 2025

"internal/common" has an entry in CODEOWNERS file
There are 1 component(s) that have owners but are present in ALLOWLIST file

Looks like we'll need to update the template used by githubgen first before this goes in.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 24, 2025

This can be fixed with open-telemetry/opentelemetry-go-build-tools#669

@atoulme atoulme merged commit 45b553c into open-telemetry:main Mar 4, 2025
162 checks passed
@atoulme atoulme deleted the make_internal_common_metadata branch March 4, 2025 05:34
@github-actions github-actions bot added this to the next release milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants