[exporter/Sematext] Second PR of New component: Sematext Exporter #37642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @andrzej-stencel |
|
@andrzej-stencel we have PR 3 (of 5) in the queue, if you could please review/OK this one. |
There was a problem hiding this comment.
Can you please adjust the README's configuration section to describe the configuration options exactly as implemented in this PR and none others? This will make it much easier to review and follow the changes with subsequent pull requests. Also please explicitly state in the README which config properties are required and what are the defaults for the optional properties.
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
andrzej-stencel
approved these changes
Mar 5, 2025
|
Can you please merge main and fix conflicts? |
atoulme
reviewed
Mar 6, 2025
atoulme
reviewed
Mar 6, 2025
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Antoine Toulme <antoine@toulme.name>
|
Thanks!! @atoulme |
atoulme
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Second PR of New component: Sematext Exporter. Basic Implementation of Metrics.
Link to tracking Issue:
#36465