Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowsservicereceiver wireframe #37712

Merged
merged 24 commits into from
Mar 4, 2025

Conversation

shalper2
Copy link
Contributor

@shalper2 shalper2 commented Feb 5, 2025

Description

Create a metric receiver to relay the status of a Windows Service. This is a wireframe for the receiver to be implemented.

Link to tracking issue

Fixes 31377

Testing

None

Documentation

Basic documentation has been written/generated by mdatagen.

@shalper2 shalper2 changed the title wirefram with generated code windowsservicereceiver wireframe Feb 5, 2025
@shalper2 shalper2 force-pushed the 31377-wsr-wireframe branch from ba02e88 to 3515845 Compare February 10, 2025 15:17
@dehaansa
Copy link
Contributor

What's the difference between this and #35362 ?

@shalper2
Copy link
Contributor Author

the level of implementation. the first one turned into an actual component which was out of scope for the original PR.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @shalper2 - various minor suggestions.

If you give rights to push to your branch I can help resolving things like https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13312274770/job/37177669827#step:8:376

@shalper2 shalper2 force-pushed the 31377-wsr-wireframe branch from a3e7c55 to 152b856 Compare February 27, 2025 15:07
@pjanotti pjanotti self-assigned this Feb 27, 2025
@shalper2 shalper2 marked this pull request as ready for review February 28, 2025 19:40
@shalper2 shalper2 requested a review from a team as a code owner February 28, 2025 19:40
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, can't speak to the windows specific knowledge though. @pjanotti please review and approve as additional codeowner.

@pjanotti
Copy link
Contributor

LGTM @atoulme

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Feb 28, 2025
type: string

metrics:
windows.service:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this metric name right? Shouldn't it be windows.service.status? I'd be partial to dropping the windows prefix from it & the attributes but that's just my preference, I think the name not having status feels incorrect.

Copy link
Contributor

@pjanotti pjanotti Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of adding status. The windows.service prefix on the metric name seems reasonable since the metric is specific to Windows Services. However, it becomes redundant to add windows.service to the attributes, just name and startup_mode seems reasonable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metric and attributes renamed per above comment d1e0072

@atoulme atoulme removed the ready to merge Code review completed; ready to merge by maintainers label Feb 28, 2025
@dehaansa dehaansa added the ready to merge Code review completed; ready to merge by maintainers label Mar 4, 2025
@atoulme atoulme merged commit e6db2f1 into open-telemetry:main Mar 4, 2025
167 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows Service status metrics
4 participants