-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windowsservicereceiver wireframe #37712
Conversation
ba02e88
to
3515845
Compare
What's the difference between this and #35362 ? |
the level of implementation. the first one turned into an actual component which was out of scope for the original PR. |
a5b4c17
to
4d993db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @shalper2 - various minor suggestions.
If you give rights to push to your branch I can help resolving things like https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13312274770/job/37177669827#step:8:376
d01ebce
to
bef32b9
Compare
2414fb2
to
f1ee46a
Compare
a3e7c55
to
152b856
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm, can't speak to the windows specific knowledge though. @pjanotti please review and approve as additional codeowner.
LGTM @atoulme |
type: string | ||
|
||
metrics: | ||
windows.service: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this metric name right? Shouldn't it be windows.service.status
? I'd be partial to dropping the windows
prefix from it & the attributes but that's just my preference, I think the name not having status
feels incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of adding status
. The windows.service
prefix on the metric name seems reasonable since the metric is specific to Windows Services. However, it becomes redundant to add windows.service
to the attributes, just name
and startup_mode
seems reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metric and attributes renamed per above comment d1e0072
Description
Create a metric receiver to relay the status of a Windows Service. This is a wireframe for the receiver to be implemented.
Link to tracking issue
Fixes 31377
Testing
None
Documentation
Basic documentation has been written/generated by mdatagen.